Skip to content

Conversation

@alextse-bg
Copy link
Contributor

No description provided.

@alextse-bg alextse-bg force-pushed the WP-EBE-testing branch 2 times, most recently from 7268b9b to 043d293 Compare June 13, 2025 14:54
@alextse-bg alextse-bg marked this pull request as ready for review June 13, 2025 15:55
@alextse-bg alextse-bg requested a review from pranavjain97 June 13, 2025 15:55
@alextse-bg alextse-bg force-pushed the WP-EBE-testing branch 3 times, most recently from ee6e10f to 5389a58 Compare June 13, 2025 16:47
Copy link
Contributor

@pranavjain97 pranavjain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u also add some test cases to hande errors from KMS?

kmsNock.done();
});

// it('should half-sign a multisig transaction successfully', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@pranavjain97 pranavjain97 merged commit fccaff0 into master Jun 18, 2025
3 checks passed
@pranavjain97 pranavjain97 deleted the WP-EBE-testing branch June 18, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants